Reviewed: https://review.openstack.org/642186 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8c2a16796bb8a17c311ff6b34435283650976f48 Submitter: Zuul Branch: master
commit 8c2a16796bb8a17c311ff6b34435283650976f48 Author: Slawek Kaplonski <[email protected]> Date: Sat Mar 9 01:07:03 2019 +0100 Fix fullstack test_dscp_marking_packets test Fullstack test test_dscp_marking_packets spawns tcpdump process inside one fake vm's namespace and then tries to ping this instance from second one. After that it checks if tcdump captured any packet marked with specific DSCP mark. Ping was done usually only once (1 packet) because it was done by using vm.wait_until_ping() method, so it could happen sometimes that ping was send before tcpdump actually started captuting traffic. In such case test failed because there was no any packet captured. This patch changes this by: 1. Start tcpdump async process with block=True, so it should be already really started before test will go to the next steps, 2. Send always 10 packets instead of (usually) only one. In addition this patch adds logging of captured tcpdump's stdout and stderr streams. It may help debugging issues with this test in the future. Change-Id: I23bbde59af0250267843623dde2c5407059d9db2 Closes-Bug: #1818335 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1818335 Title: Fullstack test test_dscp_marking_packets fails Status in neutron: Fix Released Bug description: Fullstack test test_dscp_marking_packets from fullstack module neutron.tests.fullstack.test_qos failed at least 3 times in last few days. It failed for both Linuxbridge and OVS agent so it doesn't looks like L2 backend specified. Example of failure: http://logs.openstack.org/35/638635/2/check /neutron-fullstack/675a247/logs/testr_results.html.gz Logstash query: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%20%5C%22line%20497%2C%20in%20test_dscp_marking_packets%5C%22 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1818335/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
