Public bug reported: There are some misuse of assertTrue/assertFalse in unit tests. They should be fixed.
https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/services/placement_report/test_plugin.py#L191 self.assertTrue(mech_driver, mechanism_test.TestMechanismDriver) https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/notifiers/test_nova.py#L170 self.assertFalse(event, None) https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/notifiers/test_nova.py#L236 self.assertFalse(send_events.called, False) ** Affects: neutron Importance: Undecided Assignee: Takashi NATSUME (natsume-takashi) Status: New ** Changed in: neutron Assignee: (unassigned) => Takashi NATSUME (natsume-takashi) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1819982 Title: Misuse of assertTrue/assertFalse Status in neutron: New Bug description: There are some misuse of assertTrue/assertFalse in unit tests. They should be fixed. https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/services/placement_report/test_plugin.py#L191 self.assertTrue(mech_driver, mechanism_test.TestMechanismDriver) https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/notifiers/test_nova.py#L170 self.assertFalse(event, None) https://github.com/openstack/neutron/blob/add5347f9dbdc5f5857a975731d65b51d890afdb/neutron/tests/unit/notifiers/test_nova.py#L236 self.assertFalse(send_events.called, False) To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1819982/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
