Reviewed: https://review.openstack.org/640762 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ff5f74d5d0d5ef8f7c07ca8762b7ad197aea156f Submitter: Zuul Branch: master
commit ff5f74d5d0d5ef8f7c07ca8762b7ad197aea156f Author: mareklycka <[email protected]> Date: Fri Mar 1 13:00:07 2019 +0100 Fixes double loading in Image source loading This patch removes a redundant image API call, which caused images to be loaded twice in the UI. Image filtering for snapshot/'normal' images has been merged into a single iteration for the sake of optimization. Additionally, tests have been changed to more comprehensively check which data is loaded into which data structures during model population. Code redundancy has also been removed in tests. Change-Id: Ie78900dae54ff63d41b7ddca3fa83f627d4260c4 Closes-Bug: #1818508 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1818508 Title: Image source failure Status in OpenStack Dashboard (Horizon): Fix Released Bug description: When launching instances through the NG dialog, Images can't be selected as source. To reproduce: 1) Open the launch instance dialog 2) Open the "Source" tab/step 3) Select "Image" in the "Select Boot Source" dropdown => No options for Images are displayed in the bottom portion of the dialog => The browser JS console displays: Error: [ngRepeat:dupes] Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: row in ctrl.tableData.displayedAvailable track by row.id... To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1818508/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
