Reviewed: https://review.openstack.org/642295 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8fec1ffc833eba9b3fc5f812bf881f44b4beba0c Submitter: Zuul Branch: master
commit 8fec1ffc833eba9b3fc5f812bf881f44b4beba0c Author: Slawek Kaplonski <[email protected]> Date: Sun Mar 10 22:45:15 2019 +0100 Set initial ha router state in neutron-keepalived-state-change Sometimes in case of HA routers it may happend that keepalived will set status of router to MASTER before neutron-keepalived-state-change daemon will spawn "ip monitor" to monitor changes of IPs in router's namespace. In such case neutron-keepalived-state-change process will never notice that keepalived set router to be MASTER and L3 agent will not be notified about that so router will not be configured properly. To avoid such race condition neutron-keepalived-state-change will now check if VIP address is already configured on ha interface before it will spawn "ip monitor". If it is already configured by keepalived, it will notify L3 agent that router is set to MASTER. Change-Id: Ie3fe825d65408fc969c478767b411fe0156e9fbc Closes-Bug: #1818614 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1818614 Title: Various L3HA functional tests fails often Status in neutron: Fix Released Bug description: Recently many L3 HA related functional tests are failing. The common thing in all those errors is fact that it fails when waiting for l3 ha router to become master. Example stack trace: ft2.12: neutron.tests.functional.agent.l3.test_ha_router.LinuxBridgeL3HATestCase.test_ha_router_lifecycle_StringException: Traceback (most recent call last): File "neutron/tests/base.py", line 174, in func return f(self, *args, **kwargs) File "neutron/tests/base.py", line 174, in func return f(self, *args, **kwargs) File "neutron/tests/functional/agent/l3/test_ha_router.py", line 81, in test_ha_router_lifecycle self._router_lifecycle(enable_ha=True, router_info=router_info) File "neutron/tests/functional/agent/l3/framework.py", line 274, in _router_lifecycle common_utils.wait_until_true(lambda: router.ha_state == 'master') File "neutron/common/utils.py", line 690, in wait_until_true raise WaitTimeout(_("Timed out after %d seconds") % timeout) neutron.common.utils.WaitTimeout: Timed out after 60 seconds Example failure: http://logs.openstack.org/79/633979/21/check/neutron- functional-python27/ce7ef07/logs/testr_results.html.gz Logstash query: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22ha_state%20%3D%3D%20'master')%5C%22 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1818614/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
