Reviewed: https://review.openstack.org/640847 Committed: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/commit/?id=8bbf899ec0c1ce5a9a500d680dac2391b8149a96 Submitter: Zuul Branch: master
commit 8bbf899ec0c1ce5a9a500d680dac2391b8149a96 Author: Manjeet Singh Bhatia <[email protected]> Date: Mon Mar 4 11:59:57 2019 -0800 add assert to ping test Change-Id: I24055036e6d45b5eff1cd127e2a2c78485287587 Closes-Bug: #1818233 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1818233 Title: ping_ip_address used without assertion in Neutron Tempest Plugin Status in neutron: Fix Released Bug description: The Neutron Tempest Plugin has an ping_ip_address helper in: neutron_tempest_plugin/scenario/base.py It's used in several places: git grep -n ping_ip_address | cut -d":" -f1-2 neutron_tempest_plugin/scenario/base.py:313 neutron_tempest_plugin/scenario/test_basic.py:39 neutron_tempest_plugin/scenario/test_security_groups.py:118 neutron_tempest_plugin/scenario/test_security_groups.py:146 neutron_tempest_plugin/scenario/test_security_groups.py:152 neutron_tempest_plugin/scenario/test_security_groups.py:178 neutron_tempest_plugin/scenario/test_security_groups.py:193 neutron_tempest_plugin/scenario/test_security_groups.py:208 neutron_tempest_plugin/scenario/test_security_groups.py:261 neutron_tempest_plugin/scenario/test_security_groups.py:292 In all places it's used without an assertion. Meaning that if the ping fails, it'll timeout (CONF.validation.ping_timeout), then continue the test as if nothing happened. The test will not necessarily fail. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1818233/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
