Reviewed: https://review.openstack.org/645066 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ffbe0e2f2f96556f4476ea3873af1bc628c879ca Submitter: Zuul Branch: master
commit ffbe0e2f2f96556f4476ea3873af1bc628c879ca Author: Akihiro Motoki <[email protected]> Date: Thu Mar 21 16:41:37 2019 +0900 network topology: handle port AZ correctly Previously d3 version of the network topology view handles ports with device_owner 'compute:nova' and 'compute:None' specially. This leads to the situtaion that neutron ports with non-default AZ are not shown properly. There is no reason to handle neutron ports with the default AZ differently. What we would like to do is just to classify neutron ports attached to nova servers. This commit changes the logic to check device_owner of ports have a prefix 'compute:'. Note that we also need to check if device_owner is a string before checking the prefix. Change-Id: I472bae9af3d14d8a31efcae8a7610b84c4f09c3d Closes-Bug: #1820260 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1820260 Title: Network topology graph incorrectly renders instances in non-default availability zone Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Instances not in the default availability zone (which is 'nova' by default) are displayed incorrectly in the Network topology graph in Horizon - as shown in the attached image. If you drag the errant instance you can see it is actually rendered outside the scope of the 'colour bubble', whereas instances in the default availability zone are always kept within the 'colour bubble' however much you attempt to drag them out. Looking at https://github.com/openstack/horizon/blame/master/openstack_dashboard/static/js/horizon.networktopology.js it seems that checks are made against port.device_owner to see if it matches the value 'compute:nova', but for instances in other availability zones, the value is not 'compute:nova' but 'compute:name- of-other-az'. I think it would be sufficient to change the checks to be port.device_owner.startsWith("compute:") but I have not yet been able to test this. This bug is present in all versions of Horizon since the 'curvature topology' was introduced in Liberty in 2015. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1820260/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
