Reviewed: https://review.openstack.org/638821 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3c66b40dbd23e3f792a86da5a15c993c52c9b377 Submitter: Zuul Branch: master
commit 3c66b40dbd23e3f792a86da5a15c993c52c9b377 Author: Takashi NATSUME <[email protected]> Date: Sat Feb 23 00:56:23 2019 +0900 Override the 'get' method in DriverBlockDevice class The following methods are overridden in DriverBlockDevice class. * __getattr__ * __getitem__ The 'get' method is not overridden. The value cannot be got by the 'get' method though the value can be got by '__getattr__' (e.g. bdm.volumd_id) or '__getitem__' (e.g. bdm['volume_id']) method. So override the 'get' method to fix the issue. Change-Id: Ic665fc1956831110937d98553e526cb909e49997 Closes-Bug: #1816938 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1816938 Title: Misleading log message "Booting with blank volume" in nova-compute when booting from real volume Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) rocky series: In Progress Status in OpenStack Compute (nova) stein series: In Progress Bug description: Something is broken here: https://github.com/openstack/nova/blob/af78b13c24d4abf393d17ac57e9135204ef12b73/nova/virt/block_device.py#L836 Because I'm seeing this getting logged: https://github.com/openstack/nova/blob/af78b13c24d4abf393d17ac57e9135204ef12b73/nova/virt/block_device.py#L855 When I know I'm booting from an existing volume. This is also all over the CI logs: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Booting%20with%20blank%20volume%20at%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d My guess is something with dict get() access changed on the DriverVolumeBlockDevice code with this change: https://github.com/openstack/nova/commit/b958bf1126aea8b88ccebb43a330fc1a44717145 #diff-40dadeaa854473fb72fa4bf3491a434f If I change the code to check: if bdm.volume_id: ... Then I get the expected log message but that is probably dangerous if we have a non-volume BDM. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1816938/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
