Reviewed: https://review.openstack.org/647605 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cf13b2f0cc18fdb1d512ecfe9f2c65ad4bb284dd Submitter: Zuul Branch: master
commit cf13b2f0cc18fdb1d512ecfe9f2c65ad4bb284dd Author: Slawek Kaplonski <[email protected]> Date: Mon Mar 25 21:54:52 2019 +0100 Check if process' cmdline is "space separarated" According to proc man page process arguments in /proc/{pid}/cmdline should be separated with '\0' char and that char was used in neutron.agent.linux.utils.get_cmdline_from_pid function. Recently in fullstack tests it was noticed that sometimes it may happend that those arguments are separated with space char and this caused failed test because async_process.AsyncProcess() was not able to check that process is really active. This patch adds attempt to split cmdline arguments with space in case when split with '\0' returns only 1 element. Change-Id: I35d4c0e2cf56fc3ff15cf307aaf11a8ad8489e1f Closes-Bug: #1820870 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1820870 Title: Fullstack tests are failing because async_process is not started properly Status in neutron: Fix Released Bug description: Various fullstack tests are failing because of some issues with connection to rabbitmq. Example of such failure: http://logs.openstack.org/86/643486/8/check /neutron-fullstack/9fe648e/logs/testr_results.html.gz and log from agents: http://logs.openstack.org/86/643486/8/check/neutron- fullstack/9fe648e/logs/dsvm-fullstack- logs/TestDscpMarkingQoSLinuxbridge.test_dscp_marking_clean_port_removed /neutron-linuxbridge-agent--2019-03-19-- 12-12-33-931856.txt.gz?level=ERROR All agents in such case can't connect to rabbitmq, errors in logs are like: AMQP server on 240.44.122.1:5672 is unreachable: [Errno 101] ENETUNREACH. Trying again in 4 seconds.: OSError: [Errno 101] ENETUNREACH Logstash query: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22ENETUNREACH%5C%22%20AND%20build_name%3A%5C %22neutron-fullstack%5C%22 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1820870/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
