Reviewed: https://review.openstack.org/649775 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3301449e736af81fdbd96fd3f396dd01b02beaf2 Submitter: Zuul Branch: master
commit 3301449e736af81fdbd96fd3f396dd01b02beaf2 Author: Matt Riedemann <[email protected]> Date: Wed Apr 3 22:09:52 2019 -0400 Remove CellMappingPayload database_connection and transport_url fields Change I019e88fabd1d386c0d6395a7b1969315873485fd in Stein, which is not yet officially released, exposes the unencrypted database_connection URL and MQ transport_url to a CellMapping in the select_destinations versioned notification CellMappingPayload. While notifications are not meant to be consumed by end users of the cloud but only internal services of the deployment, it still seems like a bad idea to give the keys to the nova cell DB and MQ to an external-to-nova service like ceilometer. This change removes the fields from the CellMappingPayload and bumps the major version to 2.0 to signal the change to consumers, although I don't expect anything is consuming this yet but we should follow standard versioning procedure anyway. Note that notification consumers do not request a specific payload version nor do they get a schema to perform their own backporting, they just get what they get, so after this there should be no worry about needing to support the 1.0 format for this payload. Change-Id: Ib5edea32d15db01000e6730aebceaf119daf8c5c Closes-Bug: #1823104 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1823104 Title: CellMappingPayload in select_destinations versioned notification sends sensitive database_connection and transport_url information Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) stein series: In Progress Bug description: As of this change in Stein: https://review.openstack.org/#/c/508506/28/nova/notifications/objects/request_spec.py@334 Which is not yet officially released, but is in the 19.0.0.0rc1, the select_destinations versioned notification payload during a move operation (resize, cold/live migrate, unshelve, evacuate) will send the cell database_connection URL and MQ transport_url information which contains credentials to connect directly to the cell DB and MQ, which even though notifications are meant to be internal within openstack services, seems like a pretty bad idea. IOW, just because it's internal to openstack doesn't mean nova needs to give ceilometer the keys to it's cell databases. There seems to be no justification in the change for *why* this information was needed in the notification payload, it seemed to be added simply for completeness. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1823104/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
