Reviewed: https://review.opendev.org/654457 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=13278be9f265e237fc68ee60acfacaa1df68522e Submitter: Zuul Branch: master
commit 13278be9f265e237fc68ee60acfacaa1df68522e Author: Eric Fried <[email protected]> Date: Fri Apr 19 15:35:21 2019 -0500 Fix {min|max}_version in ironic Adapter setup Change If625411f40be0ba642baeb02950f568f43673655 introduced nova.utils.get_ksa_adapter, which accepts min_version and max_version kwargs to be passed through to the ksa Adapter constructor. These are supposed to represent minimum and maximum *major* API versions, min_version was erroneously set to *microversions* when setting up the Adapter for ironicclient. This commit changes it to a major version. (Microversion negotiation is done within ironicclient itself.) Also, this bug went latent for several releases because a) it only seems to be triggered when region_name is given in the conf; but also b) ironicclient has code to discover a reasonable endpoint if passed None. So this change also adds a warning log if we try and fail to discover the endpoint via ksa. Change-Id: I34a3f8d4a496217eb01790e2d124111625bf5f85 Closes-Bug: #1825583 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1825583 Title: Region name isn't respected when configuring ironic Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) queens series: New Status in OpenStack Compute (nova) rocky series: New Status in OpenStack Compute (nova) stein series: New Bug description: When you configure a region_name for Ironic, an endpoint isn't properly passed on to the ironic client. This means that the region_name won't be respected. The current workaround is to provide an api_endpoint (or endpoint_override) for Ironic. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1825583/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
