Reviewed: https://review.opendev.org/648123 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ab7c968b6f66404c032f62a952e353f94d3be165 Submitter: Zuul Branch: master
commit ab7c968b6f66404c032f62a952e353f94d3be165 Author: Francois Palin <[email protected]> Date: Tue Mar 26 15:22:40 2019 -0400 Include all network devices in nova diagnostics get_instance_diagnostics expected all interfaces to have a <target> element with a "dev" attribute in the instance XML. This is not the case for VFIO interfaces (<interface type="hostdev">). This caused an IndexError when looping over the interfaces. This patch fixes this issue by retrieving interfaces data directly from the guest XML and adding nics appropriately to the diagnostics object. Change-Id: I8ef852d449e9e637d45e4ac92ffc5d1abd8d31c5 Closes-Bug: #1821798 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1821798 Title: nova diagnostics command is not working with all interfaces Status in OpenStack Compute (nova): Fix Released Bug description: When running nova diagnostics on instances with SR-IOV interfaces, we get: $ nova diagnostics iperf-server ERROR (ClientException): Unexpected API Error. Please report this at http://bugs.launchpad.net/nova/ and attach the Nova API log if possible. <type 'exceptions.IndexError'> (HTTP 500) (Request-ID: req-ae9445f6-558c-45c3-bdb2-b9fe6bbf186c) To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1821798/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
