Reviewed: https://review.opendev.org/666845 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8ecad3ca4b3ebb655440ad926de5029e0d2ccc1b Submitter: Zuul Branch: master
commit 8ecad3ca4b3ebb655440ad926de5029e0d2ccc1b Author: Rodolfo Alonso Hernandez <[email protected]> Date: Fri Jun 21 13:57:26 2019 +0000 Remove some synchronization decorators from ip_lib Removed the synchronization from the following ip_lib functions: * create_netns * remove_netns * list_netns The mentioned bug #1811515 and the corresponding patch [1], explain the problem of Pyroute2 NetNS class and the file descriptors used in a multithread environment. This is why, until a fix is applied to this library, a synchronization decorator was applied to all Pyroute2 commands. However, the listed functions do not instantiate this class. These three methods only handle the filesystem in order to create, remove or list the system namespaces. That means those methods are not affected by the mentioned bug in Pyroute2 and it is safe to execute them without any synchronization. [1] https://review.opendev.org/#/c/631275/ Change-Id: I71521efbdaf9bb6d7cd9650f77c52bf6e02c9ced Closes-Bug: #1833717 Related-Bug: #1811515 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1833717 Title: Functional tests: error during namespace creation Status in neutron: Fix Released Bug description: This error has happened several times during the last week: http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22line%20977,%20in%20create_network_namespace%5C%22 Those are the functional tests affected (most of them, several times): neutron.tests.functional.agent.linux.test_linuxbridge_arp_protect.LinuxBridgeARPSpoofTestCase.test_arp_correct_protection_allowed_address_pairs neutron.tests.functional.agent.linux.test_linuxbridge_arp_protect.LinuxBridgeARPSpoofTestCase.test_arp_correct_protection neutron.tests.functional.agent.linux.test_linuxbridge_arp_protect.LinuxBridgeARPSpoofTestCase.test_arp_protection_dead_reference_removal neutron.tests.functional.agent.linux.test_l3_tc_lib.TcLibTestCase.test_set_ip_rate_limit neutron.tests.functional.agent.linux.test_l3_tc_lib.TcLibTestCase.test_clear_ip_rate_limit neutron.tests.functional.agent.linux.test_l3_tc_lib.TcLibTestCase.test_delete_filter_ids neutron.tests.functional.agent.linux.test_l3_tc_lib.TcLibTestCase.test_get_filter_id_for_ip neutron.tests.functional.agent.linux.test_l3_tc_lib.TcLibTestCase.test_clear_all_filters neutron.tests.functional.agent.linux.test_l3_tc_lib.TcLibTestCase.test_get_existing_filter_ids neutron.tests.functional.agent.test_l2_lb_agent.LinuxBridgeAgentTests.test_vlan_QinQ_subinterfaces neutron.tests.functional.agent.test_l2_lb_agent.LinuxBridgeAgentTests.test_ensure_trunk_subports Regards. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1833717/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
