Reviewed: https://review.opendev.org/667061 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b203fbc5af8e2f7a6e8f4156cdb1bb12473feea5 Submitter: Zuul Branch: master
commit b203fbc5af8e2f7a6e8f4156cdb1bb12473feea5 Author: He Jie Xu <[email protected]> Date: Mon Jun 24 18:44:03 2019 +0800 Correct the comment of RequestSpec's network_metadata The network_metadata won't be persisted inside RequestSpec obj. https://github.com/openstack/nova/blob/ff0f33cf7e44c5d01f3fb999295eff4508c24a14/nova/objects/request_spec.py#L533 But there is comment said the network_metadata field should be assigned before creating the RequestSpec obj, that is incorrect description. This patch removes that comment, also adds some notes for the fields which isn't persisted in RequestSpec obj. Change-Id: I0ef451a6bac8f5caa837be62a0c2b335b9ed776b Closes-Bug: 1834005 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1834005 Title: the network metadata in request spec shouldn't be persistent Status in OpenStack Compute (nova): Fix Released Bug description: The network metadata shouldn't be persistent https://github.com/openstack/nova/blob/aa3581ad44ef915477b27349f3be4c818deee80c/nova/compute/api.py#L1039 But this patch https://review.opendev.org/#/c/586742/4 move the create after assigning the network metadata To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1834005/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
