Reviewed: https://review.opendev.org/670948 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=cdb752f3d3601cb8cca48f28d6b95d2dbc9e1e20 Submitter: Zuul Branch: master
commit cdb752f3d3601cb8cca48f28d6b95d2dbc9e1e20 Author: Takashi NATSUME <[email protected]> Date: Tue Jul 16 13:57:08 2019 +0900 Remove test_pre_live_migration_instance_has_no_fixed_ip Remove the following unit test because it is not useful any more. * test_pre_live_migration_instance_has_no_fixed_ip in nova/tests/unit/compute/test_compute.py Change-Id: I9edd70d36e7a8f40501ace574d5ae4b576a3e0ff Closes-Bug: #1836692 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1836692 Title: Wrong unit test for pre_live_migration method in compute manager Status in OpenStack Compute (nova): Fix Released Bug description: In nova/tests/unit/compute/test_compute.py, the following method does not check the right method. def test_pre_live_migration_instance_has_no_fixed_ip(self): # Confirm that no exception is raised if there is no fixed ip on # pre_live_migration self.compute.driver.pre_live_migration( test.MatchType(nova.context.RequestContext), test.MatchType(objects.Instance), {'block_device_mapping': []}, mock.ANY, mock.ANY, mock.ANY) The test method was mentioned in https://review.opendev.org/#/c/330297/ . It was necessary to follow it up. The follow-up patch was https://review.opendev.org/#/c/340713/, but it has not been merged. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1836692/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
