Reviewed: https://review.opendev.org/682025 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4e0e0a6dd26fac7d4051b0982ca20081eede8573 Submitter: Zuul Branch: master
commit 4e0e0a6dd26fac7d4051b0982ca20081eede8573 Author: Takashi NATSUME <[email protected]> Date: Fri Sep 13 20:05:49 2019 +0900 Fix a misuse of assertGreaterEqual In a notification sample functional test, there is a misuse of assertGreaterEqual. At least 6 notifications are expected, So the order of the arguments should be reversed. Change-Id: I865c215a13fa3bb72e191382187ea8368885846f Closes-Bug: #1843885 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1843885 Title: Misuse of assertGreaterEqual in a notification functional test Status in OpenStack Compute (nova): Fix Released Bug description: At [1], there is a misuse of assertGreaterEqual self.assertGreaterEqual(6, len(fake_notifier.VERSIONED_NOTIFICATIONS), It should be as follows: self.assertGreaterEqual(len(fake_notifier.VERSIONED_NOTIFICATIONS), 6 https://github.com/openstack/nova/blob/db5caf2ff8f33e8b3e7f28f041127ee4ac8b1897/nova/tests/functional/notification_sample_tests/test_instance.py#L316-L317 [1] https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertGreaterEqual To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1843885/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
