Reviewed: https://review.opendev.org/681016 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ab4320edb4661f74465ec49166f8d35b8216035f Submitter: Zuul Branch: master
commit ab4320edb4661f74465ec49166f8d35b8216035f Author: Brian Haley <bha...@redhat.com> Date: Mon Sep 9 09:51:30 2019 -0400 Only notify nova of port status changes if configured Although notify_nova_on_port_status_changes defaults to true, it could be to false, making the nova_notifier attribute unsafe to use without checking. This patch checks both the config option and that the attribute exists, since the config could be changed after the plugin is already initialized without the nova_notifier attribute being set. Change-Id: Ide0f93275e60dffda10b7da59f6d81c5582c3849 Closes-bug: #1843269 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1843269 Title: Nova notifier called even if set to False Status in networking-ovn: New Status in neutron: Fix Released Bug description: If the config option notify_nova_on_port_status_changes is set to False, the Nova notifier can still be called in update_device_up(). This could throw an exception because plugin.nova_notifier is not initialized otherwise. Since it defaults to True we've never seen this failure. To manage notifications about this bug go to: https://bugs.launchpad.net/networking-ovn/+bug/1843269/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : yahoo-eng-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp