Public bug reported: In change https://github.com/openstack/nova/commit/be548a3396ee5f3a78b2b8b59321eb4c4530f7fb the libvirt xml generation was refactored to reduce code complexity.
while this was inteded to have no fucntional change it unintentionally change when the random number generator woudl be enabled the old code https://github.com/openstack/nova/commit/be548a3396ee5f3a78b2b8b59321eb4c4530f7fb#diff-f4019782d93a196a0d026479e6aa61b1L4037-L4071 has a miss placed comment that the contence of the if block only applied to the qemu guest agent # Qemu guest agent only support 'qemu' and 'kvm' hypervisor if CONF.libvirt.virt_type in ('qemu', 'kvm'): ... the if is instead gurading so that the block actully run only when qemu and kvm is used and the body of the if has code for both the qemu guest agent and the random number generator in the refactor the code to add the rng was added to the code for adding the qemu guest agent and as a result it would only be added if botht the rng and qemu guest agent are both enabled. ** Affects: nova Importance: Medium Assignee: sean mooney (sean-k-mooney) Status: Triaged ** Tags: libvirt -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1851497 Title: rng is only enabled if qemu guest agent is enabled Status in OpenStack Compute (nova): Triaged Bug description: In change https://github.com/openstack/nova/commit/be548a3396ee5f3a78b2b8b59321eb4c4530f7fb the libvirt xml generation was refactored to reduce code complexity. while this was inteded to have no fucntional change it unintentionally change when the random number generator woudl be enabled the old code https://github.com/openstack/nova/commit/be548a3396ee5f3a78b2b8b59321eb4c4530f7fb#diff-f4019782d93a196a0d026479e6aa61b1L4037-L4071 has a miss placed comment that the contence of the if block only applied to the qemu guest agent # Qemu guest agent only support 'qemu' and 'kvm' hypervisor if CONF.libvirt.virt_type in ('qemu', 'kvm'): ... the if is instead gurading so that the block actully run only when qemu and kvm is used and the body of the if has code for both the qemu guest agent and the random number generator in the refactor the code to add the rng was added to the code for adding the qemu guest agent and as a result it would only be added if botht the rng and qemu guest agent are both enabled. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1851497/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
