Reviewed: https://review.opendev.org/705695 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=321afc8f897c8132ddc6edd2b59285111d0d73e0 Submitter: Zuul Branch: master
commit 321afc8f897c8132ddc6edd2b59285111d0d73e0 Author: Bence Romsics <[email protected]> Date: Tue Feb 4 14:02:30 2020 +0100 Move rejection of min-bw rule on non-physnet port to the ovs qos driver The ovs qos driver only supports the min-bw rule on physnet ports. However other (future) qos drivers may support the min-bw rule on non-physnet ports too, therefore implementing the rejection of the unsupported combination in the qos plugin was a bug. This change moves the rejection from the qos plugin to the ovs qos driver. Change-Id: I02d77a03c411dc8ab303a7d7b53d7ea93cc9f4c6 Closes-Bug: #1861442 Depends-On: https://review.opendev.org/705694 Related-Bug: #1819029 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1861442 Title: QOS minimum bandwidth rejection of non-physnet network and updates should be driver specific Status in neutron: Fix Released Bug description: When adding a qos policy to a network or port, there is the following check in the qos_plugin: # minimum-bandwidth rule is only supported (independently of # drivers) on networks whose first segment is backed by a physnet if rule.rule_type == qos_consts.RULE_TYPE_MINIMUM_BANDWIDTH: net = network_object.Network.get_object( context, id=port.network_id) physnet = net.segments[0].physical_network if physnet is None: raise qos_exc.QosRuleNotSupported(rule_type=rule.rule_type, port_id=port['id']) To my knowledge this statement is simply untrue as it is precisly the reference drivers which have this problem, not necessarily all drivers. This blocks me from creating a qos_driver that does support mimimum bandwidth without a physnet. The same goes for min_bw_rule_updates when the port is bound. I propose we move those checks to the qos_drivers themselves. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1861442/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
