Reviewed: https://review.opendev.org/663382 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b3e14931d6aac6ee5776ce1e6974c75a5a6b1823 Submitter: Zuul Branch: master
commit b3e14931d6aac6ee5776ce1e6974c75a5a6b1823 Author: Stephen Finucane <[email protected]> Date: Wed Jun 5 16:39:45 2019 +0100 Unplug VIFs as part of cleanup of networks If an instance fails to build, which is possible for a variety of reasons, we may end up in a situation where we have remnants of a plugged VIF (typically files) left on the host. This is because we cleanup from the neutron perspective but don't attempt to unplug the VIF, a call which may have many side-effects depending on the VIF driver. Resolve this by always attempting to unplug VIFs as part of the network cleanup. A now invalid note is also removed and a unit test corrected. Closes-Bug: #1831771 Related-Bug: #1830081 Signed-off-by: Stephen Finucane <[email protected]> Change-Id: Ibdbde4ed460a99b0cbe0d6b76e0e5b3c0650f9d9 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1831771 Title: UnexpectedDeletingTaskStateError exception can leave traces of VIFs on host Status in OpenStack Compute (nova): Fix Released Bug description: This was originally reported in Bugzilla https://bugzilla.redhat.com/show_bug.cgi?id=1668159 The 'UnexpectedDeletingTaskStateError' exception can be raised by something like aborting a large heat stack, where the instance hasn't finished setting up before the stack is aborted and the instances deleted. https://github.com/openstack/nova/blob/19.0.0/nova/db/sqlalchemy/api.py#L2864 We handle this in the compute manager and as part of that handling, we clean up the resource tracking of network interfaces. https://github.com/openstack/nova/blob/19.0.0/nova/compute/manager.py#L2034-L2040 However, we don't unplug these interfaces. This can result in things being left over on the host. We should attempt to unplug VIFs as part of this cleanup. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1831771/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
