Reviewed: https://review.opendev.org/703632 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2b55e3f7a7d1acbd10d57742b6f1c70d7b848916 Submitter: Zuul Branch: master
commit 2b55e3f7a7d1acbd10d57742b6f1c70d7b848916 Author: Radomir Dopieralski <[email protected]> Date: Tue Jan 21 15:46:14 2020 +0100 Catch AttributeError when deleting temp file on image upload When the image upload finishes, we try to delete the temporary file that was used for the upload. However, depending on how Horizon is deployed, instead of a file it can be a BytesIO instance, which leads to an AttributeError. This happens in a separate thread, so Horizon itself doesn't crash, but it's better to catch that exception. Change-Id: Iaa66d9c87060c1e001f3f6e31f630d6092df55d3 Closes-Bug: #1866632 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1866632 Title: AttributeError on file upload Status in OpenStack Dashboard (Horizon): Fix Released Bug description: When the image upload finishes, we try to delete the temporary file that was used for the upload. However, depending on how Horizon is deployed, instead of a file it can be a BytesIO instance, which leads to an AttributeError. This happens in a separate thread, so Horizon itself doesn't crash, but it's better to catch that exception. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1866632/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
