Reviewed: https://review.opendev.org/653738 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ec93474a84aff1c184a58fe436ea4a0842bd9825 Submitter: Zuul Branch: master
commit ec93474a84aff1c184a58fe436ea4a0842bd9825 Author: Ivaylo Mitev <[email protected]> Date: Thu Apr 18 05:36:22 2019 -0700 VMware VMDK detach: get adapter type from instance VM Detach VMDK using adapter type from instance instead of shadow VM. Closes-Bug: #1835733 Change-Id: I8668d57f6b302ad8cdc1e4af28cf6bb8145a738d ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1835733 Title: VMware VMDK volume detach fails Status in OpenStack Compute (nova): Fix Released Bug description: Description =========== Volume detaching incorrectly fails when shadow VM adapter type is IDE and instance VM adapter type is not IDE. Steps to reproduce ================== * Get a volume with shadow VM adapter type IDE * Get a server with non-IDE adapter type * Attach the volume to the server * Attempt to detach the volume from the server (while server is powered-on) Expected result =============== Detach must be successful since adapter type on server instance VM is not IDE hence no need for the instance VM to be powered-off. Actual result ============= Detach failed complaining about IDE not supporting hotplug. The incorrect logic is here https://github.com/openstack/nova/blob/766d13218763f43ba91c2a15adff438a0dd84e37/nova/virt/vmwareapi/volumeops.py#L519-L528. Environment =========== 1. Exact version of OpenStack you are running. Queens 2. Which hypervisor did you use? vSphere 6.5 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1835733/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
