Public bug reported: While we build_instances() we should cleanup arqs if the _create_and_bind_arqs() failed.
In _cleanup_when_reschedule_fails()[1] we clean the arqs if _create_and_bind_arqs() failed, but I think we just only clean it at L847 if the _create_and_bind_arqs() failed [3]. If we add "compute_utils.delete_arqs_if_needed(context, instance)"[2] in _cleanup_when_reschedule_fails()[1], once we call _cleanup_when_reschedule_fails() it will be cleanup arqs with 'accel:device_profile' in instance's flavor, I think that will increase Nova's call to Cyborg (by cyborgclinet). We should reduce the number of calls to Cyborg with cyborgclient. [1]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L582 [2]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L598 [3]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L848-L849 ** Affects: nova Importance: Undecided Assignee: Brin Zhang (zhangbailin) Status: New ** Changed in: nova Assignee: (unassigned) => Brin Zhang (zhangbailin) -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1872934 Title: Accurately clean up ARQs resources during build_instances() in conductor Status in OpenStack Compute (nova): New Bug description: While we build_instances() we should cleanup arqs if the _create_and_bind_arqs() failed. In _cleanup_when_reschedule_fails()[1] we clean the arqs if _create_and_bind_arqs() failed, but I think we just only clean it at L847 if the _create_and_bind_arqs() failed [3]. If we add "compute_utils.delete_arqs_if_needed(context, instance)"[2] in _cleanup_when_reschedule_fails()[1], once we call _cleanup_when_reschedule_fails() it will be cleanup arqs with 'accel:device_profile' in instance's flavor, I think that will increase Nova's call to Cyborg (by cyborgclinet). We should reduce the number of calls to Cyborg with cyborgclient. [1]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L582 [2]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L598 [3]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L848-L849 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1872934/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
