Reviewed: https://review.opendev.org/742758 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fe440bdd6be190588ec4310ef9630285c0acfec6 Submitter: Zuul Branch: master
commit fe440bdd6be190588ec4310ef9630285c0acfec6 Author: Flavio Fernandes <[email protected]> Date: Thu Jul 23 19:02:34 2020 -0400 [ovn]: gracefully handle logical switch ports with tag set to None AddLSwitchPortCommand takes kwargs as columns and tag is one of them. It is possible that tag is provided with the value None and that is not valid. The proposed change gracefully handles such cases so the transaction is not aborted. Change-Id: I0f3cb6f534072e166610b417059acbe89302473a Closes-Bug: #1888736 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1888736 Title: [OVN]: creating a local switch port that has no tags should not fail Status in neutron: Fix Released Bug description: When creating a network, I see the following error (full log attached): Jul 23 20:52:06 stack neutron-server[27492]: DEBUG neutron.api.rpc.handlers.resources_rpc [None req-6ac75e1f-c23b-46c4 -9b5a-14e14c235959 admin admin] Pushing event updated for resources: {'Network': ['ID=0ab805f8-a386-413c-be2a- 88240cf5d4af,revision_number=1']} {{(pid=27516) push /opt/stack/neutron/neutron/api/rpc/handlers/resources_rpc.py:243}} Jul 23 20:52:06 stack neutron-server[27492]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n=1 command(idx=0): LsAddCommand(switch=neutron-0ab805f8-a386-413c-be2a-88240cf5d4af, columns={'external_ids': {'neutron:network_name': 'public', 'neutron:mtu': '1500', 'neutron:revision_number': '1'}, 'other_config': {'mcast_snoop': 'false', 'mcast_flood_unregistere\ d': 'false'}}, may_exist=True) {{(pid=27516) do_commit /usr/local/lib/python3.6/dist-packages/ovsdbapp/backend/ovs_idl/transaction.py:87}} Jul 23 20:52:06 stack neutron-server[27492]: DEBUG ovsdbapp.backend.ovs_idl.transaction [-] Running txn n=1 command(idx=1): AddLSwitchPortCommand(lport=provnet-4ad8f85e- e7af-4437-8556-73892bff4076, lswitch=neutron-0ab805f8-a386-413c-be2a- 88240cf5d4af, may_exist=True, columns={'addresses': ['unknown'], 'external_ids': {}, 'type': 'localnet', 'tag': None, 'options': {'network_name': 'public'}}) {{(pid=27516) do_commit /usr/local/lib/python3.6/dist- packages/ovsdbapp/backend/ovs_idl/transaction.py:87}} Jul 23 20:52:06 stack neutron-server[27492]: ERROR ovsdbapp.backend.ovs_idl.vlog [-] attempting to write bad value to column tag (ovsdb error: expected integer, got <class 'NoneType'>): ovs.db.error.Error: ovsdb error: expected integer, got <class 'NoneType'> Steps to reproduce: Create a public network in openstack cluster?!? To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1888736/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
