Reviewed: https://review.opendev.org/716186 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d94ea23d3d64ecd3f2539a337c066487b938fcad Submitter: Zuul Branch: master
commit d94ea23d3d64ecd3f2539a337c066487b938fcad Author: Sundar Nadathur <[email protected]> Date: Mon Mar 30 19:24:30 2020 -0700 Delete ARQs by UUID if Cyborg ARQ bind fails. During the reivew of the cyborg series it was noted that in some cases ARQs could be leaked during binding. See https://review.opendev.org/#/c/673735/46/nova/conductor/manager.py@1632 This change adds a delete_arqs_by_uuid function that can delete unbound ARQs by instance uuid. This change modifies build_instances and schedule_and_build_instances to handel the AcceleratorRequestBindingFailed exception raised when binding fails and clean up instance arqs. Co-Authored-By: Wenping Song <[email protected]> Closes-Bug: #1872730 Change-Id: I86c2f00e2368fe02211175e7328b2cd9c0ebf41b Blueprint: nova-cyborg-interaction ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1872730 Title: Delete ARQs for an instance when the instance is deleted only delete bound arqs Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) ussuri series: In Progress Bug description: During development of the cyborg integration with nova the patch that Delete ARQs for an instance when the instance is deleted Icb95890d8f16cad1f7dc18487a48def2f7c9aec2 failed to do so in some cases as noted in https://review.opendev.org/#/c/673735/46/nova/conductor/manager.py@1632 if the arq are successfully created in the conductor and then the binding fails those arqs would be leaked as they never entered the bound state. As a result if the instance was deleted the ARQs that were created for the instance but not bound would not be deleted when the instance bound ARQs are clean up. This bug tracks addressing that edge case. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1872730/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
