Reviewed: https://review.opendev.org/730176 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3c8079666fba823467f3ff803c4d82ba9e9d0b82 Submitter: Zuul Branch: master
commit 3c8079666fba823467f3ff803c4d82ba9e9d0b82 Author: zhaoleilc <[email protected]> Date: Fri May 22 10:57:01 2020 +0800 Fix an erroneous grammar in explanatory notes This patch changes 'The volumes already detached' to 'The volumes have already been detached' at 2983 line in nova/ compute/manager.py Change-Id: I9a312527097b8ce7862616522cecd61b3576a71d Closes-Bug: #1880057 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1880057 Title: An erroneous grammar in explanatory notes in nova Status in OpenStack Compute (nova): Fix Released Bug description: Description =========== There is an erroneous grammar in explanatory notes in nova and its specific location is at "https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L2983";. The note says "The volumes already detached during the above _shutdown_instance() call and this is why detach is not requested from _cleanup_volumes() in this case", but I think it should say "The volumes have already been detached during the above _shutdown_instance() call and this is why detach is not requested from _cleanup_volumes() in this case". Steps to reproduce ================== None Expected result =============== None Actual result ============= None Environment =========== The master branch of nova. Logs & Configs ============== None To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1880057/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
