Reviewed: https://review.opendev.org/750799 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0a785e90c32a8e96e61ad6353fdc75b04e97e357 Submitter: Zuul Branch: master
commit 0a785e90c32a8e96e61ad6353fdc75b04e97e357 Author: Terry Wilson <[email protected]> Date: Wed Sep 9 17:30:55 2020 +0000 [OVN] Fix get/update/delete of non-OVN agents At some point, KeyError stopped being raised by get_agent and instead the AgentNotFound exception. This meant that the patched plugin methods would not be called for {get,update,delete}_agent calls for non-OVN agents. Change-Id: Id755a9eec08414d7a77e67a426d7796fae693ac7 Closes-Bug: #1895033 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1895033 Title: When using ml2/OVN with other plugins with agents, non-OVN agents are broken for show/update/delete operations Status in neutron: Fix Released Bug description: ml2/ovn mech driver overrides the ML2 agent API methods and inserts its results if the agent passed to the operations are OVN agents. Due to a change where KeyError is no longer raised by get_agent, the get_agent/update_agent/delete_agent methods no longer fall back to the original ML2 plugin for non-OVN agents. For an example, one can just insert a bogus agent into the neutron db like: INSERT into agents (id, agent_type, `binary`, topic, host, created_at, started_at, heartbeat_timestamp, configurations) VALUES('8dcb72d1-c1bc-46ab-86a0-823183178791', 'test', '/bin/test', 'topic', 'localhost.localdomain', '2020-01-01', '2020-01-01', '2020-01-01', ''); and do openstack network agent list to verify it is there, and then openstack network agent show 8dcb72d1-c1bc-46ab-86a0-823183178791 to verify that it is broken (or delete/update --description) To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1895033/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
