Reviewed: https://review.opendev.org/734814 Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a4a549a1814a9ea9f142fd8ec5928fe9cfebc269 Submitter: Zuul Branch: master
commit a4a549a1814a9ea9f142fd8ec5928fe9cfebc269 Author: pedh <[email protected]> Date: Wed Jun 10 18:18:00 2020 +0800 Fix: Page crashes on instance confirm resize Add error handling to instance confirm/revert resize methods. Change-Id: I128049091f38e8db3c1524a5c4cb932f3e809714 Closes-Bug: #1882918 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1882918 Title: Instances page crashes on repeated confirm/revert resize actions Status in OpenStack Dashboard (Horizon): Fix Released Bug description: Environment: OpenStack Rocky/Ussuri compute node of libvirt/kvm on HP Proliant server with 24*cpu and 256GB mem Reproduction steps: 1. Create an instance with flavor "m1.small"; 2. Resize the instance to flavor "m1.medium"; 3. In a while the instance enters "VERIFY_RESIZE" state, and the "Confirm Resize/Migration" button is enabled, we click the button and wait for the button to be enabled again, and then click the button repeatedly; 4. The page crashes after the resize is done. Error log: http://ix.io/2oOd Bug analysis: The bug reproduces easily, if the instance stays in VERIFY_RESIZE state for long enough. After digging into the horizon source code, I found that "ConfirmResize.single" and "RevertResize.single" methods in "openstack_dashboard/dashboards/project/instance/tables.py" are lack of exception handling, and expose the exception to django, to cause the page crash. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1882918/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
