Reviewed: https://review.opendev.org/742363 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=20b138ff3118029e86f0525695160c4c7ca8b551 Submitter: Zuul Branch: master
commit 20b138ff3118029e86f0525695160c4c7ca8b551 Author: Matt Vinall <[email protected]> Date: Thu Jul 9 21:08:21 2020 +0100 fix dhcp bulk reload exceptions 1886969 - The bulk reload code was written for python2 and caused an exception running under python3. This change works under python3. 1890027 - There was an additional exception triggered when deleting networks - reading the network from the cache returned 'None' and this was not properly checked before use. Change-Id: I4e546c0e37146b1f34d8b5e6637c407b0c04ad4d Closes-Bug: 1886969 Closes-Bug: 1890027 Signed-off-by: Matt Vinall <[email protected]> ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1890027 Title: dhcp agent crashes when deleting network if bulk reload enabled Status in neutron: Fix Released Bug description: If DHCP bulk reload is enabled, I get the following crash in the bulk reload loop when deleting a network: Running command: 'neutron-dhcp-agent --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/dhcp_agent.ini' + exec neutron-dhcp-agent --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/dhcp_agent.ini Traceback (most recent call last): File "/usr/lib/python3.6/site-packages/eventlet/hubs/hub.py", line 461, in fire_timers timer() File "/usr/lib/python3.6/site-packages/eventlet/hubs/timer.py", line 59, in __call__ cb(*args, **kw) File "/usr/lib/python3.6/site-packages/neutron/agent/dhcp/agent.py", line 161, in _reload_bulk_allocations self.call_driver('bulk_reload_allocations', network) File "/usr/lib/python3.6/site-packages/osprofiler/profiler.py", line 160, in wrapper result = f(*args, **kwargs) File "/usr/lib/python3.6/site-packages/neutron/agent/dhcp/agent.py", line 167, in call_driver {'net': network.id, 'action': action}) AttributeError: 'NoneType' object has no attribute 'id' + sudo -E kolla_set_configs Line numbers might differ slightly due to my patch for https://bugs.launchpad.net/neutron/+bug/1886969 but the issue is present without my change. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1890027/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
