Reviewed: https://review.opendev.org/757620 Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4dca7fae87d9bea01e01f786465fdb4d8231dc69 Submitter: Zuul Branch: master
commit 4dca7fae87d9bea01e01f786465fdb4d8231dc69 Author: elajkat <[email protected]> Date: Tue Oct 6 13:20:06 2020 +0200 Keepalived version check [0] introduced keepalived_use_no_track config option which defaults to True. Here I add and extra runtime check to check keepalived version, and only if that version is bigger than 2.0.0 add the no_track option to the keepalived config file. [0] https://review.opendev.org/745641 Change-Id: I16dce5b3faf62ce02535170a1b0e1ad22ee8ac30 Closes-Bug: #1896506 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1896506 Title: keepalived_use_no_track default=True breaks bionic deploys Status in Ubuntu Cloud Archive: Invalid Status in Ubuntu Cloud Archive stein series: New Status in Ubuntu Cloud Archive train series: New Status in Ubuntu Cloud Archive ussuri series: New Status in neutron: Fix Released Status in neutron package in Ubuntu: Confirmed Bug description: [Impact] In the latest Neutron stable release, a new config option was introduced to control using no_track in Keepalived. This config options defaults to true which is broken on releases before Focal. The proposed fix for this in earlier releases is to change the default to False. [Test Case] TBD [Regression Potential] The regression potential is low as the fix is changing a configuration default. -------------------------------------------------------------------------- Presumably the default of keepalived_use_no_track default=True breaks bionic deploys and the patch [1] has been backported to several bionic-based stable branches with a conflicting default config value; it's been backported back to stable/rocky. [1] https://review.opendev.org/#/c/747862/1 This doesn't seem like a good backport to stable branches without having some logic in it that detects the version of keepalived and sets the default appropriately based on that version. More discussion with slaweq from #openstack-neutron: coreycb> Corey Bryant slaweq: about this backport, will it break deployments that are on bionic? https://review.opendev.org/#/c/747857/1 10:40 AM I don't think there are any stein deployments on focal 11:06 AM <slaweq> Sławek Kapłoński coreycb: what keepalived version is available on Bionic? 11:06 AM coreycb: ahh, ok it's 1.x 11:06 AM <coreycb> Corey Bryant slaweq: correct 1.x 11:06 AM <slaweq> Sławek Kapłoński so it should be set to False on Bionic 11:10 AM → armax joined ⇐ priteau quit 11:12 AM <coreycb> Corey Bryant slaweq: it would be really nice to if we could detect the version and set it appropriately Can we revert this for all releases prior to Ussuri? For Ubuntu, Ussuri is available by default with Focal, but we also backport Ussuri to bionic so we would have to change the default for keepalived_use_no_track default to False for bionic. To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1896506/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
