Reviewed: https://review.opendev.org/c/openstack/neutron/+/785581 Committed: https://opendev.org/openstack/neutron/commit/130655cdb98f493d0ceda72e2c3a0649c3d9024d Submitter: "Zuul (22348)" Branch: master
commit 130655cdb98f493d0ceda72e2c3a0649c3d9024d Author: Oleg Bondarev <[email protected]> Date: Fri Apr 9 11:52:29 2021 +0300 DHCP notification optimization DHCP notification is done after each create/update/delete for network, subnet and port. This notification currently has to retrieve network from DB almost every time, which is a quite heavy DB request and hence affects performance of port and subnet CRUD. This patch suggests 2 optimizations: - do not fetch network if not needed (only fetch when schedule needed) - for port and subnet AFTER_CREATE event pass network dict from plugin According to Rally tests these changes improve performance: - port create ~20% - port update ~20% - subnet create ~15% - port delete and subnet update/delete - not tested Closes-Bug: #1923161 Change-Id: I0ab836ac09225f4f3ad435e9ceaf315018855d52 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1923161 Title: DHCP notification could be optimized Status in neutron: Fix Released Bug description: DHCP notification is done after each create/update/delete for network, subnet and port [1]. This notification currently has to retrieve network from DB each time, which is a quite heavy DB request and hence affects performance of port and subnet CRUD [2]. 2 proposals: - not fetch network when it's not needed - pass network dict from plugin [1] https://github.com/openstack/neutron/blob/bdd661d21898d573ef39448316860aa4c692b834/neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py#L111-L120 [2] https://github.com/openstack/neutron/blob/bdd661d21898d573ef39448316860aa4c692b834/neutron/api/rpc/agentnotifiers/dhcp_rpc_agent_api.py#L200 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1923161/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
