Reviewed: https://review.opendev.org/c/openstack/neutron/+/785830 Committed: https://opendev.org/openstack/neutron/commit/109faeac7e2e37da3bb7d5014a37ef18ed8cb80a Submitter: "Zuul (22348)" Branch: master
commit 109faeac7e2e37da3bb7d5014a37ef18ed8cb80a Author: elajkat <[email protected]> Date: Mon Apr 12 09:54:59 2021 +0200 trivial: Make driver_controller's _attrs_to_driver py3 compatible In python3 dict.values() doesn't return list but instead dict_values, it must be converted to list to "enjoy" list operations like insert. Add unit tests to be sure. Closes-Bug: #1923423 Change-Id: Ie270ac2ee65c02bdb099d11af7f1d2fb62ad0f61 ** Changed in: neutron Status: Triaged => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1923423 Title: l3_router.service_providers DriverController's _attrs_to_driver is not py3 compatible Status in neutron: Fix Released Bug description: Currently l3_router.service_providers.DriverController._attrs_to_driver has the following: ... drivers = self.drivers.values() # make sure default is tried before the rest if defined if self.default_provider: drivers.insert(0, self.drivers[self.default_provider]) As in python3 dict.values() gives back "dict_values" instead of list, insert will fail with: "AttributeError: 'dict_values' object has no attribute 'insert'" To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1923423/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
