Reviewed: https://review.opendev.org/c/openstack/nova/+/789374 Committed: https://opendev.org/openstack/nova/commit/86af7feed06f08ddb3ef65122089216708d53a06 Submitter: "Zuul (22348)" Branch: master
commit 86af7feed06f08ddb3ef65122089216708d53a06 Author: Tobias Urdin <[email protected]> Date: Mon May 3 17:25:43 2021 +0200 Stop leaking ceph df cmd in RBD utils If the ceph df command fails in the get_pool_info method of RBD utils the actual command executed if seen by the users in the fault error message. This hides the command behind a StorageError exception and logs the exception instead of leaking it to the users. Change-Id: I6e3a73f2e04d1a7636daf96d5af73c9cf2fbe220 Closes-Bug: 1926978 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1926978 Title: Leaking username and backend in RBD driver Status in OpenStack Compute (nova): Fix Released Bug description: The RBD utils get_pool_info() function raises an processutils.ProcessExecutionError from oslo.concurrency if it fails. That error message contains the Ceph username and the fact that it's running Ceph in the error message that a end-user can view. | fault | {"code": 500, "created": "2021-05-03T14:00:57Z", "message": "Exceeded maximum number of retries. Exceeded max scheduling attempts 3 for instance 28c36a23-8e2b-4425-aeb3-502c536f43e8. Last exception: Unexpected error while running command. | | | Command: ceph df --format=json --id openstack --conf /etc/ceph/ceph.conf This information should not be available to end-users. To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1926978/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
