Reviewed: https://review.opendev.org/c/openstack/nova/+/793512 Committed: https://opendev.org/openstack/nova/commit/56eb253e9febccf721df6bca4eb851ad26cb70a6 Submitter: "Zuul (22348)" Branch: master
commit 56eb253e9febccf721df6bca4eb851ad26cb70a6 Author: melanie witt <[email protected]> Date: Fri May 28 00:26:04 2021 +0000 Honor [neutron]http_retries in the manual client Change Ifb3afb13aff7e103c2e80ade817d0e63b624604a added a nova side config option for specifying neutron client retries that maps to the ksa connect_retries config option to provide parity with the cinder and glance clients that have nova side config options. That change missed passing CONF.neutron.http_retries to the manual client used for calling the port binding API. This sets the connect_retries attribute on the manual ksa client so http_retries will be honored. Closes-Bug: #1929886 Related-Bug: #1866937 Change-Id: I8296e4be9f0706fab043451b856efadbb7bd41f6 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1929886 Title: [neutron]http_retries config option not used when calling the port binding API Status in OpenStack Compute (nova): Fix Released Status in OpenStack Compute (nova) rocky series: New Status in OpenStack Compute (nova) stein series: New Status in OpenStack Compute (nova) train series: New Status in OpenStack Compute (nova) ussuri series: New Status in OpenStack Compute (nova) victoria series: New Status in OpenStack Compute (nova) wallaby series: New Bug description: Discovered downstream [1] that the [neutron]http_retries config option has no effect on calls to the port binding API, so calls to it are not resilient like our other calls to the neutron API. The neutronclient didn't have support for the port binding API at the time when nova needed to call it, so a manual ksa client was created in the interim. When the [neutron]http_retries config option was added [2], this manual client was missed and thus never does any retries. The backportable fix for this will pass the CONF.neutron.http_retries option to the ksa client and the following proposed change to use the now existing neutronclient support should be reviewed and merged to prevent future similar bugs: https://review.opendev.org/c/openstack/nova/+/706295 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1955031 [2] https://review.opendev.org/c/openstack/nova/+/712226 To manage notifications about this bug go to: https://bugs.launchpad.net/nova/+bug/1929886/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
