Reviewed: https://review.opendev.org/c/openstack/neutron/+/820911 Committed: https://opendev.org/openstack/neutron/commit/ef162fcf8ed288ddab5c0e38eeb31f09106673eb Submitter: "Zuul (22348)" Branch: master
commit ef162fcf8ed288ddab5c0e38eeb31f09106673eb Author: Rodolfo Alonso Hernandez <[email protected]> Date: Tue Dec 7 16:52:53 2021 +0000 Provide a "priority" value to the OVN events Since [1], the OVN events are sorted by a "priority" value. In "TestOvnDbNotifyHandler" tests, because several events are added to the watch list, this "priority" value should be given. The workaround [2] is removed as is unnecessary now. NOTE: this patch will work with newer ovsdbapp versions (still not released) and current one. CI testing master branch of ovsdbapp could be found in "openstack-tox-py36-with-ovsdbapp-master". [1]https://review.opendev.org/c/openstack/ovsdbapp/+/819116 [2]https://review.opendev.org/c/openstack/neutron/+/755335 Closes-Bug: #1953481 Change-Id: If76cf263a2c13eb278a5e22743b5962919c2ad98 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1953481 Title: openstack-tox-py36-with-ovsdbapp-master job is failing every day since 12.03.2021 Status in neutron: Fix Released Bug description: Failure example: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a93/periodic/opendev.org/openstack/neutron/master/openstack- tox-py36-with-ovsdbapp-master/a93ba3a/testr_results.html Failed test: neutron.tests.unit.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_ovsdb_monitor.TestOvnDbNotifyHandler.test_watch_and_unwatch_events Stacktrace: ft1.2: neutron.tests.unit.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_ovsdb_monitor.TestOvnDbNotifyHandler.test_watch_and_unwatch_eventstesttools.testresult.real._StringException: Traceback (most recent call last): File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 183, in func return f(self, *args, **kwargs) File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovsdb_monitor.py", line 119, in test_watch_and_unwatch_events self.handler.watch_event(networking_event) File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py36/lib/python3.6/site-packages/ovsdbapp/event.py", line 151, in watch_event self._add(event) File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py36/lib/python3.6/site-packages/ovsdbapp/event.py", line 131, in _add self._get_queue(event).add(event) File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py36/lib/python3.6/site-packages/ovsdbapp/event.py", line 124, in _get_queue return self._queues.setdefault(event.priority, set()) File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py36/lib/python3.6/site-packages/sortedcontainers/sorteddict.py", line 541, in setdefault self._list_add(key) File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py36/lib/python3.6/site-packages/sortedcontainers/sortedlist.py", line 1798, in add key = self._key(value) File "/home/zuul/src/opendev.org/openstack/neutron/.tox/py36/lib/python3.6/site-packages/ovsdbapp/event.py", line 112, in <lambda> self._queues = sortedcontainers.SortedDict(lambda p: -p) TypeError: bad operand type for unary -: 'Mock' To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1953481/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
