Reviewed: https://review.opendev.org/c/openstack/neutron/+/822051 Committed: https://opendev.org/openstack/neutron/commit/c6a6c5ae127a97856c880da3f82257977a06a571 Submitter: "Zuul (22348)" Branch: master
commit c6a6c5ae127a97856c880da3f82257977a06a571 Author: Slawek Kaplonski <[email protected]> Date: Thu Dec 16 22:25:27 2021 +0100 [Functional] Fix expected number of the enqueue_state_change calls In the HA router's keepalived state change monitor tests, it was expected that enqueue_state_change method will be called 3 or 4 times. But after some changes in the keepalived_state_change monitor which were done some time ago, it may be now that it will be called just 2 or 3 times: - 2 when initial status will be "primary" and it will be just transition to "backup", - 3 when initial status will be "backup", then it will transition to "primary" and finally to "backup" again. To reflect those 2 possibilities, test was changed that it will expect 2 or 3 calls and will check only that last 2 will be always transition to "primary" and then to "backup". Additionally this patch adds some extra logging in that test so it will be easier to check what was going on in that test. Closes-Bug: #1954751 Change-Id: Ib5de7e65839f52c35c43801969e3f0c16dead5bb ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1954751 Title: Functional test test_keepalived_state_change_notification timeouts waiting for enque_state_change monitor calls to be made Status in neutron: Fix Released Bug description: Test failure: ft1.3: neutron.tests.functional.agent.l3.test_ha_router.LinuxBridgeL3HATestCase.test_keepalived_state_change_notificationtesttools.testresult.real._StringException: Traceback (most recent call last): File "/home/zuul/src/opendev.org/openstack/neutron/neutron/common/utils.py", line 711, in wait_until_true eventlet.sleep(sleep) File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.8/site-packages/eventlet/greenthread.py", line 36, in sleep hub.switch() File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.8/site-packages/eventlet/hubs/hub.py", line 313, in switch return self.greenlet.switch() eventlet.timeout.Timeout: 60 seconds During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 183, in func return f(self, *args, **kwargs) File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 183, in func return f(self, *args, **kwargs) File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/agent/l3/test_ha_router.py", line 49, in test_keepalived_state_change_notification common_utils.wait_until_true(lambda: File "/home/zuul/src/opendev.org/openstack/neutron/neutron/common/utils.py", line 716, in wait_until_true raise WaitTimeout(_("Timed out after %d seconds") % timeout) neutron.common.utils.WaitTimeout: Timed out after 60 seconds Example: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d32/797537/33/check/neutron- functional-with-uwsgi/d325301/testr_results.html Logstash query: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22line%2049%2C%20in%20test_keepalived_state_change_notification%5C%22 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1954751/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
