Reviewed: https://review.opendev.org/c/openstack/neutron/+/815962 Committed: https://opendev.org/openstack/neutron/commit/abfbe5d54d9d3992638efbb49d5a4145fe99ff7a Submitter: "Zuul (22348)" Branch: master
commit abfbe5d54d9d3992638efbb49d5a4145fe99ff7a Author: Balazs Gibizer <[email protected]> Date: Fri Oct 29 15:32:13 2021 +0200 Do not block qos for direct-physical ports Today the sriov qos service plugin blindly blocks creating ports with minimum bandwidth qos and with direct_physical vnic_type. This was originally added when only dataplane enforcement was the scope of the qos service plugin. However in the last many releases we created placement enforcement for this qos rule regardless of the vnic_type. So now blindly blocking the port creation is now preventing using the placement enforcement for this rule for direct_physical ports. This patch removes this limitation by marking minimum bandwidth as supported rule for the sriov qos service plugin. The limitation that data plane enforcement is not supported for this rule remains. The agent will not even try to apply any kind of rules to these ports as port binding is not forwarded for the sriov agent at all. The documentation is extended to explain that placement enforcement now works while data plane enforcement still not supported. This is somewhat similar to the case when the support for egress direction is added to the minimum bandwidth rule, while the sriov data plane enforcement was not (could not) been implemented for this direction in the sriov agent. Today the sriov agent simply ignores the egress direction rules in the minimum bandwidth qos rule during applying the data plane enforcement. Closes-Bug: #1949877 Change-Id: I20ad32eac414ff90b551bff940d92cbcfa848101 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1949877 Title: direct-physical port creation fails with QoS minimum bandwidth rule Status in neutron: Fix Released Bug description: Today the sriov qos service plugin blindly blocks creating ports with minimum bandwidth qos and with direct_physical vnic_type. This was originally added when only dataplane enforcement was the scope of the qos service plugin. However in the last many releases we created placement enforcement for this qos rule regardless of the vnic_type. So now blindly blocking the port creation is now preventing using the placement enforcement for this rule for direct_physical ports. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1949877/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
