Reviewed: https://review.opendev.org/c/openstack/cinder/+/827860 Committed: https://opendev.org/openstack/cinder/commit/18b8033b6bd1945bd27b03b779a32a883df5fb10 Submitter: "Zuul (22348)" Branch: master
commit 18b8033b6bd1945bd27b03b779a32a883df5fb10 Author: Gorka Eguileor <[email protected]> Date: Fri Feb 4 12:42:25 2022 +0100 Fix request id mess on Cinder-API This patch fixes multiple issues related to request ids: - Duplicated request ID in logs - Missing request id header in response - Wrong request ID in response header when using noauth The source of these issues is the fact that the request ID and the request context are set too late, or not at all, in the paste filter chain. And the last bug is fixed as a freebie when the code in auth.py is refactored to reduce code duplication on setting the cinder.context key in the request's environment. The patch fixes these issue by changing the filter chains to have the request_id filter as the first filter, and using our own filter for it, to ensure that the context is correctly set. Not sure if values now defined in ENV_OVERWRITES are still necessary, so the patch preserves current behavior. Closes-Bug: #1960019 Closes-Bug: #1960020 Closes-Bug: #1960021 Closes-Bug: #1960329 Change-Id: Ide831a221a7561bbb7da193f0edb011f1989420e ** Changed in: cinder Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1960021 Title: Request to list REST API versions doesn't return the request id Status in Cinder: Fix Released Status in OpenStack Compute (nova): Confirmed Bug description: When we do a GET on the root of the REST API service to get available versions we don't get any of the expected request id headers. These headers are "x-openstack-request-id" and "x-compute-request-id" for both Cinder and Nova. To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1960021/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
