Reviewed: https://review.opendev.org/c/openstack/horizon/+/831903 Committed: https://opendev.org/openstack/horizon/commit/29da801528a357449264e546182bd629f4654275 Submitter: "Zuul (22348)" Branch: master
commit 29da801528a357449264e546182bd629f4654275 Author: Keigo Noha <[email protected]> Date: Fri Mar 4 17:38:20 2022 +0900 Change to a proper policy for Resume operation Previously, ToggleSuspend class checked 'os-rescue' policy for resuming an instance. To align to resume operation, this fix changes to 'os-suspend-server:resume'. Closes-Bug: #1963652 Change-Id: If6386ecdb81fb1f0d88dab447ee81c251b9857b7 ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/1963652 Title: ToggleSuspend doesn't check an appropriate policy Status in OpenStack Dashboard (Horizon): Fix Released Bug description: In current Horizon, ToggleSuspend doesn't check an appropriate policy. The current implementation is: ~~~ def allowed(self, request, instance=None): if not instance: return False self.suspended = instance.status == "SUSPENDED" if self.suspended: self.current_present_action = RESUME policy_rules = ( ("compute", "os_compute_api:os-rescue"),) ~~~ However, the action uses server_resume() to resume an instance. To align the policy to the actual command, it should be os_compute_api:os-suspend-server:resume To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/1963652/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
