Reviewed: https://review.opendev.org/c/openstack/nova/+/836248 Committed: https://opendev.org/openstack/nova/commit/5e6b9a86984b854d0a717cff1c2ac49412ec6f47 Submitter: "Zuul (22348)" Branch: master
commit 5e6b9a86984b854d0a717cff1c2ac49412ec6f47 Author: Takashi Kajinami <[email protected]> Date: Mon Apr 4 00:14:58 2022 +0900 Fix wrong attribute to find remote address The webob.Request class does not have the remote_address attribute but the remote_addr attribute. This change fixes usage of the non-existing attribute accordingly. Closes-Bug: #1967683 Change-Id: I874e97ac6ad84daa20997345082cb4d1135699c4 ** Changed in: nova Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Compute (nova). https://bugs.launchpad.net/bugs/1967683 Title: Wrong property to look up remote address Status in Cinder: In Progress Status in ec2-api: Fix Released Status in OpenStack Shared File Systems Service (Manila): In Progress Status in OpenStack Compute (nova): Fix Released Bug description: Currently, remote_address attribute of the Reqeust object is used to look up client address in multiple places. eg. https://github.com/openstack/cinder/blob/7086157de07b77e8b67bbb767bc2ce25e86c2f51/cinder/api/middleware/auth.py#L64 ~~~ def _set_request_context(req, **kwargs): """Sets request context based on parameters and request.""" remote_address = getattr(req, 'remote_address', '127.0.0.1') ~~~ However, webob.Request has no remote_address attribute but only remote_addr attribute. https://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1967683/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
