Reviewed: https://review.opendev.org/c/openstack/neutron/+/840146 Committed: https://opendev.org/openstack/neutron/commit/d1fe14d366e501869addff17e851ac03a599adca Submitter: "Zuul (22348)" Branch: master
commit d1fe14d366e501869addff17e851ac03a599adca Author: Miro Tomaska <[email protected]> Date: Fri May 6 13:42:11 2022 -0500 Notify mech drivers with original and modified network. Include original and modified network when notifying mechanism drivers in PRECOMMIT event. PRECOMMIT_CREATE modified network includes new segment, while original does not. Exact opposite for PRECOMMIT_DELETE Closes-Bug: #1967742 Change-Id: I364fc7981458374ed25eb8837d1ed3afff046b95 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1967742 Title: ML2 - Network Context, not possible to see original/current segments Status in neutron: Fix Released Bug description: When ML2 driver receive NetworkContext after adding network segment with: openstack network segment create \ --network e686a356-58d7-4cf0-bdf9-e720d9925ac0 \ --physical-network net3 \ --network-type vlan \ --segment 300 provision-net3 In `update_network_postcommit`, context.current and context.original both include all segments: context.current: {'id': 'e686a356-58d7-4cf0-bdf9-e720d9925ac0', 'name': 'routed_provider_net', 'segments': [ {'provider:network_type': 'vlan', 'provider:physical_network': 'net1', 'provider:segmentation_id': 100}, {'provider:network_type': 'vlan', 'provider:physical_network': 'net2', 'provider:segmentation_id': 200}, {'provider:network_type': 'vlan', 'provider:physical_network': 'net3', 'provider:segmentation_id': 300}]} context.original: {'id': 'e686a356-58d7-4cf0-bdf9-e720d9925ac0', 'name': 'routed_provider_net', 'segments': [ {'provider:network_type': 'vlan', 'provider:physical_network': 'net1', 'provider:segmentation_id': 100}, {'provider:network_type': 'vlan', 'provider:physical_network': 'net2', 'provider:segmentation_id': 200}, {'provider:network_type': 'vlan', 'provider:physical_network': 'net3', 'provi der:segmentation_id': 300}]} Expected results: context.orignial should not include the new segment on physical_network: 'net3'. Since both current and original include all segments it is not possible for ML2 plugins to know which VLAN to add on managed devices. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1967742/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
