Reviewed: https://review.opendev.org/c/openstack/neutron/+/844860 Committed: https://opendev.org/openstack/neutron/commit/a575dbc4a1aa7c44bba7ada4571a85d21120261e Submitter: "Zuul (22348)" Branch: master
commit a575dbc4a1aa7c44bba7ada4571a85d21120261e Author: Rodolfo Alonso Hernandez <[email protected]> Date: Wed May 18 03:43:40 2022 +0000 Add "max-rate" value to minimum bandwidth rules OVS translates the QoS and associated queue registers, attached to a port, into "tc" linux-htb classfull traffic shaper, applied on the port. OVS creates a "tc" root class on the port device. On top of this root class, the queues are represented as child "tc" classes. In order to define a "min-rate" value ("tc rate"), a "max-rate" value ("tc ceil") must be provided and higher than "min-rate". By default, OVS agent QoS minimum rules do not have a "max-rate" defined. Before this patch, any minimum bandwidth rule was limiting the maximum rate to 100Mbit/s, that is the default value set in "tc ceil". This patch provides the maximum "max-rate" value for any minimum bandwidth rule. Closes-Bug: #1977752 Change-Id: I2c6f09548f39cadfe85e57032091a70a5bc978e5 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/1977752 Title: [OVS][QoS] Minimum bandwidth backend enforcement does not provide max- rate values Status in neutron: Fix Released Bug description: Related Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2093739 For minimum bandwidth, the OVS agent is create a QoS policy assigned to the physical bridge interface. Any new port with a min-bw QoS rule will create a queue attached to this QoS policy. OVS creates the corresponding "tc" linux-htb policy in the interface, creating a root class. Each new queue will be represented as a new child class on top of the parent one (that represents the QoS policy). The problem we have, as commented in [1], is that we are not providing any "ceil" value (max-rate) in the parent class or the child ones. If no "ceil" value is provided, 100Mbits/s will be assigned. Any child class with a higher "rate" (min-rate) than "ceil" won't be able to set this value. [1]https://bugzilla.redhat.com/show_bug.cgi?id=2093739#c1 To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/1977752/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
