Reviewed: https://review.opendev.org/c/openstack/neutron/+/881798 Committed: https://opendev.org/openstack/neutron/commit/b19b55909dffcdc4ebbbd6d723936f8a188e3e47 Submitter: "Zuul (22348)" Branch: master
commit b19b55909dffcdc4ebbbd6d723936f8a188e3e47 Author: Slawek Kaplonski <[email protected]> Date: Fri Apr 28 09:27:14 2023 +0200 Don't set and remove immediately DEAD VLAN tag in tests In fullstack and functional tests where OVSPortFixture is used to create port in OVS bridge, just after port was created by ovs interface driver, DEAD_VLAN tag was removed from the port as it's not needed in tests. But this could cause race condition and instead of removing DEAD_VLAN tag, actually correct tag configured by e.g. neutron_openvswitch_agent was removed and traffic to such port wasn't working at all. To avoid that race, now method which adds setting DEAD_VLAN tag to the port_replace transaction is now mocked so there will be no DEAD VLAN tag set on such port at all. This patch also removes unstable test decorator from the TestDhcpAgentHA.test_multiple_agents_for_network fullstack test as it seems for me that this was the reason why this test was failing pretty often. Closes-Bug: #2000150 Change-Id: I3938c94bbd531fac461e80e791c128821a4f837f ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/2000150 Title: Fullstack dhcp test test_multiple_agents_for_network is failing intermittently Status in neutron: Fix Released Bug description: Test neutron.tests.fullstack.test_dhcp_agent.TestDhcpAgentHA.test_multiple_agents_for_network is failing pretty often recently. Stacktrace: ft1.3: neutron.tests.fullstack.test_dhcp_agent.TestDhcpAgentHA.test_multiple_agents_for_network(Linux bridge agent)testtools.testresult.real._StringException: Traceback (most recent call last): File "/home/zuul/src/opendev.org/openstack/neutron/neutron/common/utils.py", line 724, in wait_until_true eventlet.sleep(sleep) File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-fullstack-gate/lib/python3.10/site-packages/eventlet/greenthread.py", line 36, in sleep hub.switch() File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-fullstack-gate/lib/python3.10/site-packages/eventlet/hubs/hub.py", line 313, in switch return self.greenlet.switch() eventlet.timeout.Timeout: 60 seconds During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 182, in func return f(self, *args, **kwargs) File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/fullstack/test_dhcp_agent.py", line 201, in test_multiple_agents_for_network self._spawn_vm() File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/fullstack/test_dhcp_agent.py", line 75, in _spawn_vm vm.block_until_dhcp_config_done() File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/fullstack/resources/machine.py", line 217, in block_until_dhcp_config_done utils.wait_until_true( File "/home/zuul/src/opendev.org/openstack/neutron/neutron/common/utils.py", line 728, in wait_until_true raise exception neutron.tests.common.machine_fixtures.FakeMachineException: Address 10.0.0.229/24 or gateway 10.0.0.1 not configured properly on port test-veth1b4334 Failure examples: https://36ccf3feef294bb781ed-88f13fe1d2cd9b64afb4d1818492b226.ssl.cf1.rackcdn.com/866225/4/gate/neutron- fullstack-with-uwsgi/d5c1b53/testr_results.html https://51698b00592e877a0023-3a9e3dcf5065ad1abf1d1a27741d8ba4.ssl.cf1.rackcdn.com/865822/2/check/neutron- fullstack-with-uwsgi/e813f7e/testr_results.html To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/2000150/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
