Reviewed: https://review.opendev.org/c/openstack/glance/+/939250 Committed: https://opendev.org/openstack/glance/commit/e791ed565e9b1a17743306caaf5c7a086fc47aee Submitter: "Zuul (22348)" Branch: master
commit e791ed565e9b1a17743306caaf5c7a086fc47aee Author: Tobias Urdin <[email protected]> Date: Tue Jan 14 16:43:16 2025 +0100 Fix broken metadata function calls The patch [1] cleanup so that the database connection was re-used but forgot to update all function calls causing functionality to be broken. [1] https://review.opendev.org/c/openstack/glance/+/889380 Change-Id: Ic56d897c441004d710ec89a536ad57b2fe480a41 Closes-Bug: #2094816 ** Changed in: glance Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to Glance. https://bugs.launchpad.net/bugs/2094816 Title: Broken function calls in glance/db/sqlalchemy/metadata.py Status in Glance: Fix Released Bug description: The patch [1] updated a lot of functions but never corrected the function calls everywhere [1] https://review.opendev.org/c/openstack/glance/+/889380 2025-01-14 14:36:14.743 89411 CRITICAL glance [-] Unhandled error: TypeError: _update_data_in_db() missing 1 required positional argument: 'value' 2025-01-14 14:36:14.743 89411 ERROR glance Traceback (most recent call last): 2025-01-14 14:36:14.743 89411 ERROR glance File \"/bin/glance-manage\", line 8, in <module> 2025-01-14 14:36:14.743 89411 ERROR glance sys.exit(main()) 2025-01-14 14:36:14.743 89411 ERROR glance File \"/usr/lib/python3.9/site-packages/glance/cmd/manage.py\", line 570, in main 2025-01-14 14:36:14.743 89411 ERROR glance return CONF.command.action_fn(*func_args, **func_kwargs) 2025-01-14 14:36:14.743 89411 ERROR glance File \"/usr/lib/python3.9/site-packages/glance/cmd/manage.py\", line 312, in load_metadefs 2025-01-14 14:36:14.743 89411 ERROR glance metadata.db_load_metadefs(db_api.get_engine(), path, merge, 2025-01-14 14:36:14.743 89411 ERROR glance File \"/usr/lib/python3.9/site-packages/glance/db/sqlalchemy/metadata.py\", line 535, in db_load_metadefs 2025-01-14 14:36:14.743 89411 ERROR glance _populate_metadata( 2025-01-14 14:36:14.743 89411 ERROR glance File \"/usr/lib/python3.9/site-packages/glance/db/sqlalchemy/metadata.py\", line 306, in _populate_metadata 2025-01-14 14:36:14.743 89411 ERROR glance _update_data_in_db(namespaces_table, values, 2025-01-14 14:36:14.743 89411 ERROR glance TypeError: _update_data_in_db() missing 1 required positional argument: 'value' To manage notifications about this bug go to: https://bugs.launchpad.net/glance/+bug/2094816/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
