Reviewed: https://review.opendev.org/c/openstack/neutron/+/938404 Committed: https://opendev.org/openstack/neutron/commit/5292b13bbdd4e00dadbbef72400b737aab3dd0ff Submitter: "Zuul (22348)" Branch: master
commit 5292b13bbdd4e00dadbbef72400b737aab3dd0ff Author: Rodolfo Alonso Hernandez <[email protected]> Date: Fri Jan 3 14:58:41 2025 +0000 [eventlet-removal] Remove the usage of eventlet in the L3 agent This patch removes the usage of eventlet in the L3 agent. It removes the last bits using this library and changes the implementation of the WSGI server. This patch replaces the WSGI ``neutron-keepalived-state-change`` server with an implementation based on ``socketserver.ThreadingUnixStreamServer``. The ``KeepalivedStateChangeHandler`` class is now inheriting from ``socketserver.StreamRequestHandler``. This change is similar to the changes done for the Metadata agents before [1][2] This patch bumps the ``oslo.service`` library to 4.2.0, that includes [3]. Note that the requirements line is also requesting the dependencies for "threading", that install aditional libraries. [1]https://review.opendev.org/c/openstack/neutron/+/938393 [2]https://review.opendev.org/c/openstack/neutron/+/942916 [3]https://review.opendev.org/c/openstack/oslo.service/+/945720 Closes-Bug: #2087943 Change-Id: I82f7b4e4c4f165bab114a0ab5ee4948d3ee8ce63 ** Changed in: neutron Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to neutron. https://bugs.launchpad.net/bugs/2087943 Title: [eventlet-removal] Remove the usage of eventlet in the L3 agent Status in neutron: Fix Released Bug description: References: * https://etherpad.opendev.org/p/oct2024-ptg-neutron * https://etherpad.opendev.org/p/neutron-eventlet-deprecation Remove the import and usage of the eventlet library in the L3 agent. ============================================================ It is spawned using ``oslo_service.launch``. Same comment as in the OVN Neutron agent. It uses a greenpool to handle the resource processing https://github.com/openstack/neutron/blob/04e9efec78fe308b50f6f1eab8b24f29f3164684/neutron/agent/l3/agent.py#L331. Same as in the DHCP agent (https://review.opendev.org/c/openstack/neutron/+/923626), it is questionable the speed improvement of this implementation. It also uses ``eventlet.spawn`` in HA to spawn the keepalived notifications server. To manage notifications about this bug go to: https://bugs.launchpad.net/neutron/+bug/2087943/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
