Reviewed: https://review.opendev.org/c/openstack/horizon/+/960692 Committed: https://opendev.org/openstack/horizon/commit/64163a6e001f0736e8c0ba09b93ee88b66ab6c88 Submitter: "Zuul (22348)" Branch: master
commit 64163a6e001f0736e8c0ba09b93ee88b66ab6c88 Author: Dmitriy Chubinidze <[email protected]> Date: Thu Sep 11 22:08:29 2025 +0000 Revert "Making IP protocol field required" This reverts commit 9445725a9e56956ea06d4338fc4cccd9bb89ad94. Reason for revert: Making ip_protocol mandatory breaks presets in SECURITY_GROUP_RULES (e.g., "All TCP", "SSH" etc) because the field is hidden in the form. Change-Id: I3a17c8ec60e1004ae96200370791078483308af2 Closes-Bug: #2122416 Signed-off-by: Dmitriy Chubinidze <[email protected]> ** Changed in: horizon Status: In Progress => Fix Released -- You received this bug notification because you are a member of Yahoo! Engineering Team, which is subscribed to OpenStack Dashboard (Horizon). https://bugs.launchpad.net/bugs/2122416 Title: Regression: Fix for 2023362 breaks all presets Status in OpenStack Dashboard (Horizon): Fix Released Bug description: If ip_protocol is marked mandatory all presets from settings.SECURITY_GROUP_RULES like "All ICMP", "All TCP", "SSH" and so on fail silently because they hide the ip_protocol field (of course they do, it's already in the preset) and therefore the up_protocol is missing in the request. It will get set by the defaults in settings.SECURITY_GROUP_RULES but by then it's too late and the error handling is already triggered. So with patch https://opendev.org/openstack/horizon/commit/9445725a9e56956ea06d4338fc4cccd9bb89ad94 applied the addition of the rule fails but the user is not aware since the "error marker" is on the ip_protocol field, which is hidden. For the user it looks like the form is just re-rendered. Testing was broken by having ip_protocol fields added to the mock request without adding them to the form itself... Either the check must move down to where we know about the configured defaults order defaults must be propagated up to the form. To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/2122416/+subscriptions -- Mailing list: https://launchpad.net/~yahoo-eng-team Post to : [email protected] Unsubscribe : https://launchpad.net/~yahoo-eng-team More help : https://help.launchpad.net/ListHelp
