+1 for this, init() should only do all the initialization work(initializing variables etc. ), and following starting behavior works should be performed in start(), unless we have a specific reason to put those methods in init().
Jian On Sat, Aug 17, 2013 at 4:03 PM, Karthik Kambatla <[email protected]>wrote: > Hi yarn-devs, > > I ran into this during my work on RM HA - YARN-149 and co - and would > greatly appreciate any suggestions on how to go about this. > > The basic idea is to have an Active/Standby architecture the same way as in > HDFS. My approach is to init() both RMs the same way. The RMs are to behave > differently in start() - we start all services on the Active RM and only > those we want to on the Standby. > > However, post-init, some of the services are already starting, at least > they start listening on their respective ports. Examples are the scheduler, > resource tracker service etc. > > Is there a particular reason this is being done in init(). If not, it would > be nice to move the code responsible for starting these services to > serviceStart(). > > Thoughts? > > Many thanks, > Karthik > -- CONFIDENTIALITY NOTICE NOTICE: This message is intended for the use of the individual or entity to which it is addressed and may contain information that is confidential, privileged and exempt from disclosure under applicable law. If the reader of this message is not the intended recipient, you are hereby notified that any printing, copying, dissemination, distribution, disclosure or forwarding of this communication is strictly prohibited. If you have received this communication in error, please contact the sender immediately and delete it from your system. Thank You.
