Thanks for sharing, Rohith. I spent a bit times to try JCarder, but I failed to run it with maven. Could someone run it?
+1 for Karthik's idea. Thanks, - Tsuyoshi On Sun, Dec 28, 2014 at 4:11 AM, Karthik Kambatla <[email protected]> wrote: > +1 to setting up jcarder. Spandan (cc'ed here) has recently set up jcarder > on Cloudera's internal build, and should be able to help us with setting > things up. > > Regarding findbugs IS2_INCONSISTENT_SYNC exclusions, I believe those > exclusions are justified at the time of adding them. However, we don't > ensure that subsequent code changes continue to honor prior assumptions. I > am open to revisiting the existing findbugs exclusions and clearly > documenting (comments or annotations) the assumptions like a class expected > to be thread-safe ( > https://jsr-305.googlecode.com/svn/trunk/javadoc/javax/annotation/concurrent/ThreadSafe.html > ). > > What do others think? > > > On Wed, Dec 24, 2014 at 3:24 AM, Rohith Sharma K S < > [email protected]> wrote: > >> Hi >> >> For running tests with JCarder, the below blog explains very well. I think >> we can integrate it. >> http://wiki.apache.org/hadoop/HowToUseJCarder >> >> Thanks & Regards >> Rohith Sharma K S >> >> -----Original Message----- >> From: Tsuyoshi Ozawa [mailto:[email protected]] >> Sent: 24 December 2014 16:38 >> To: [email protected] >> Subject: Re: [Discuss] Reg : Integration of JCarder or any other power >> full tool which identifies suspecious deadlock cycles >> >> Rohith, >> >> Thanks for starting a useful discussion. +1 for using tools for deadlock >> detection. >> >> Before starting to use new tools, I'd like to mention findbugs: I think >> it's useful to enable findbugs to check IS2_INCONSISTENT_SYNC. >> There are lots exclusion of the rule in findbugs-exclusion.xml. I think >> some deadlock we faced could be prevented with the check. >> >> About the dynamic checker, it's useful to use it. One technical problem we >> will have is how to use it. Can we add the test with JCarder? >> >> Thanks, >> - Tsuyoshi >> >> On Wed, Dec 24, 2014 at 7:34 PM, Rohith Sharma K S < >> [email protected]> wrote: >> > >> > Hi folks, >> > >> > Recently in YARN project(last 1 year), there 12 deadlock issues or >> potential deadlock issues were detected and fixed too. And many more might >> be there also!! >> > >> > As going further in production ready releases, point of concern is, >> avoiding these type of issues that may appear in the production deployment >> which would cause severe impact and loss. So if there would be any tool >> integrated to HadoopQA by default which identifies suspicious deadlock >> cycles like JCarder, then it would be great in identifying issues in >> earlier stages rather than issue reporting after release deploy in cluster. >> > >> > Any thought or suggestions on this? >> > >> > Thanks & Regards >> > Rohith Sharma K S >> > >> > This e-mail and its attachments contain confidential information from >> HUAWEI, which is intended only for the person or entity whose address is >> listed above. Any use of the information contained herein in any way >> (including, but not limited to, total or partial disclosure, reproduction, >> or dissemination) by persons other than the intended recipient(s) is >> prohibited. If you receive this e-mail in error, please notify the sender >> by phone or email immediately and delete it! >> > >> > > > > -- > Karthik Kambatla > Software Engineer, Cloudera Inc. > -------------------------------------------- > http://five.sentenc.es
