Daniel Templeton created YARN-4421:
--------------------------------------
Summary: Remove dea code in RmAppImpl.RMAppRecoveredTransition
Key: YARN-4421
URL: https://issues.apache.org/jira/browse/YARN-4421
Project: Hadoop YARN
Issue Type: Improvement
Components: resourcemanager
Reporter: Daniel Templeton
Assignee: Daniel Templeton
Priority: Minor
The {{transition()}} method contains the following:
{code}
// Last attempt is in final state, return ACCEPTED waiting for last
// RMAppAttempt to send finished or failed event back.
if (app.currentAttempt != null
&& (app.currentAttempt.getState() == RMAppAttemptState.KILLED
|| app.currentAttempt.getState() == RMAppAttemptState.FINISHED
|| (app.currentAttempt.getState() == RMAppAttemptState.FAILED
&& app.getNumFailedAppAttempts() == app.maxAppAttempts))) {
return RMAppState.ACCEPTED;
}
// YARN-1507 is saving the application state after the application is
// accepted. So after YARN-1507, an app is saved meaning it is accepted.
// Thus we return ACCECPTED state on recovery.
return RMAppState.ACCEPTED;
{code}
The {{if}} statement is fully redundant and can be eliminated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
