Tianyin Xu created YARN-4500:
--------------------------------
Summary: Obsolete and missing default config values in docs
Key: YARN-4500
URL: https://issues.apache.org/jira/browse/YARN-4500
Project: Hadoop YARN
Issue Type: Bug
Components: documentation
Affects Versions: 2.6.2, 2.7.1
Reporter: Tianyin Xu
Sorry for firing 3 separate JIRA posts. This JIRA is related to YARN-4482 and
YARN-4499. Different from those two JIRAs, all the problems in this JIRA are
certainly doc errors and can be simply fixed by patching {{yarn-default.xml}}.
*1. Obsolete docs*
{{yarn.resourcemanager.store.class}}
In
[yarn-default.xml|https://hadoop.apache.org/docs/r2.7.1/hadoop-yarn/hadoop-yarn-common/yarn-default.xml],
the value is
{{org.apache.hadoop.yarn.server.resourcemanager.recovery.FileSystemRMStateStore}},
while it should be
{{org.apache.hadoop.yarn.server.resourcemanager.recovery.MemoryRMStateStore}}
according to the code. The only usage is listed below,
{code:title=RMStateStoreFactory.java|borderStyle=solid}
26 public class RMStateStoreFactory {
27 private static final Log LOG =
LogFactory.getLog(RMStateStoreFactory.class);
28
29 public static RMStateStore getStore(Configuration conf) {
30 Class<? extends RMStateStore> storeClass =
31 conf.getClass(YarnConfiguration.RM_STORE,
32 MemoryRMStateStore.class, RMStateStore.class);
33 LOG.info("Using RMStateStore implementation - " + storeClass);
34 return ReflectionUtils.newInstance(storeClass, conf);
35 }
36 }
{code}
\\
*2. Missing default configs*
The docs
[yarn-default.xml|https://hadoop.apache.org/docs/r2.7.1/hadoop-yarn/hadoop-yarn-common/yarn-default.xml]
miss the default values of the following parameters:
{{yarn.web-proxy.address}}
{{yarn.ipc.client.factory.class}}
{{yarn.ipc.server.factory.class}}
{{yarn.ipc.record.factory.class}}
Here you go,
{code:title=YarnConfiguration.java|borderStyle=solid}
97 /** Factory to create client IPC classes.*/
98 public static final String IPC_CLIENT_FACTORY_CLASS =
99 IPC_PREFIX + "client.factory.class";
100 public static final String DEFAULT_IPC_CLIENT_FACTORY_CLASS =
101 "org.apache.hadoop.yarn.factories.impl.pb.RpcClientFactoryPBImpl";
102
103 /** Factory to create server IPC classes.*/
104 public static final String IPC_SERVER_FACTORY_CLASS =
105 IPC_PREFIX + "server.factory.class";
106 public static final String DEFAULT_IPC_SERVER_FACTORY_CLASS =
107 "org.apache.hadoop.yarn.factories.impl.pb.RpcServerFactoryPBImpl";
108
109 /** Factory to create serializeable records.*/
110 public static final String IPC_RECORD_FACTORY_CLASS =
111 IPC_PREFIX + "record.factory.class";
112 public static final String DEFAULT_IPC_RECORD_FACTORY_CLASS =
113 "org.apache.hadoop.yarn.factories.impl.pb.RecordFactoryPBImpl";
...
1119 /** The address for the web proxy.*/
1120 public static final String PROXY_ADDRESS =
1121 PROXY_PREFIX + "address";
1122 public static final int DEFAULT_PROXY_PORT = 9099;
1123 public static final String DEFAULT_PROXY_ADDRESS =
1124 "0.0.0.0:" + DEFAULT_PROXY_PORT;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
