Prabhu Joseph created YARN-10014:
------------------------------------
Summary: Refactor boolean flag based approach in SchedConfCLI#run
Key: YARN-10014
URL: https://issues.apache.org/jira/browse/YARN-10014
Project: Hadoop YARN
Issue Type: Improvement
Reporter: Prabhu Joseph
Boolean-flag based approach in
org.apache.hadoop.yarn.client.cli.SchedConfCLI#run:
Everything is controlled with boolean flags here.
The flag hasOption is set to true in each of the if-clauses just to make the
condition below the hasOption-conditions happy. The flag is set to true even
for parameter that don't have an option (like 'getConf') at all, this is very
misleading and hard to understand for the first read.
Need below refactoring:
a. Eliminates the hasOption boolean flag
b. Where an option is misused, fail-fast: Have a method that contains this code
and call it for every option, in-place:
{code}
if (!hasOption) {
System.err.println("Invalid Command Usage: ");
printUsage();
return -1;
}
{code}
c. Remove the boolean flags: format and getConf as well. These are unnecessary.
cc [~snemeth]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
